Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes datanames() assignment and re-adds test for deprecated function #350

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Fixes datanames() assignment and re-adds test for deprecated function #350

merged 2 commits into from
Nov 11, 2024

Conversation

averissimo
Copy link
Contributor

Pull Request

Part of #333

Changes description

  • Method was incorrectly overwriting the teal_data object with their own names
  • Adds test that will continue to test the functionality until it's removed from the framework

@averissimo averissimo added the core label Nov 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  --------------------
R/cdisc_data.R                   1       0  100.00%
R/deprecated.R                  71      57  19.72%   19-344
R/dummy_function.R               2       2  0.00%    14-15
R/formatters_var_labels.R       61       0  100.00%
R/join_key.R                    38       0  100.00%
R/join_keys-c.R                 12       0  100.00%
R/join_keys-extract.R          128       0  100.00%
R/join_keys-names.R             15       0  100.00%
R/join_keys-parents.R           30       0  100.00%
R/join_keys-print.R             45       0  100.00%
R/join_keys-utils.R             73       3  95.89%   35-38
R/join_keys.R                   21       0  100.00%
R/teal_data-class.R             35       4  88.57%   71, 119-121
R/teal_data-constructor.R       31      16  48.39%   33, 36-42, 52-58, 61
R/teal_data-extract.R            3       0  100.00%
R/teal_data-get_code.R          13       8  38.46%   114-120, 124
R/teal_data-names.R              8       1  87.50%   31
R/teal_data-show.R               4       4  0.00%    14-19
R/testhat-helpers.R             26       0  100.00%
R/topological_sort.R            32       0  100.00%
R/verify.R                      42      11  73.81%   67, 97-101, 104-108
TOTAL                          691     106  84.66%

Diff against main

Filename          Stmts    Miss  Cover
--------------  -------  ------  -------
R/deprecated.R        0      -8  +11.27%
TOTAL                 0      -8  +1.16%

Results for commit: a53fe55

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited
Loading

Unit Tests Summary

  1 files   15 suites   1s ⏱️
163 tests 163 ✅ 0 💤 0 ❌
218 runs  218 ✅ 0 💤 0 ❌

Results for commit a53fe55.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
deprecated 👶 $+0.10$ $+2$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
deprecated 👶 $+0.02$ getter_returns_same_as_names_
deprecated 👶 $+0.08$ setter_does_nothing_to_object

Results for commit 66aee0a

♻️ This comment has been updated with latest results.

@m7pr m7pr self-assigned this Nov 11, 2024
@averissimo averissimo merged commit c67d840 into main Nov 11, 2024
25 checks passed
@averissimo averissimo deleted the 333_fix_datanames_assigment@main branch November 11, 2024 11:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m7pr m7pr m7pr approved these changes

Assignees

@m7pr m7pr

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@averissimo @m7pr